Skip to content

Fix basestring references in documentation#1106

Merged
jvegreg merged 2 commits into
masterfrom
basestring_to_str
May 10, 2021
Merged

Fix basestring references in documentation#1106
jvegreg merged 2 commits into
masterfrom
basestring_to_str

Conversation

@jvegreg

@jvegreg jvegreg commented May 6, 2021

Copy link
Copy Markdown
Contributor

@bouweandela spotted an old reference to basestring in the doc in #1099. This PR removes all remaining apperances of basestring

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@jvegreg jvegreg requested a review from bouweandela May 6, 2021 12:57
@jvegreg jvegreg added the documentation Improvements or additions to documentation label May 6, 2021

@bouweandela bouweandela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jvegreg jvegreg merged commit 277ae09 into master May 10, 2021
@jvegreg jvegreg deleted the basestring_to_str branch May 10, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants